test: add benchmark on AWS Lambda #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoutschen
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
- Coverage 99.81% 99.75% -0.07%
===========================================
Files 76 79 +3
Lines 2763 2839 +76
Branches 113 118 +5
===========================================
+ Hits 2758 2832 +74
- Misses 4 5 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
heitorlessa
suggested changes
Jan 13, 2021
|
Haha I glanced too quickly at them then |
nmoutschen
changed the title
|
@heitorlessa You might want to set a baseline and publish results between each release to track regressions. Either as a simple json file or something funky like this: https://simonwillison.net/2020/Oct/9/git-scraping/ |
|
Before we merge this, open question: Right now, this depends on |
|
Create a bucket under Powertools account - this will get us closer to
automate and check for regressions
…On Wed, 20 Jan 2021 at 08:49, Nicolas Moutschen ***@***.***> wrote:
Before we merge this, open question:
Right now, this depends on sam deploy --guided which require user inputs.
Should I create an S3 bucket for deployment artefacts (similar to what I
did here
<https://github.com/aws-samples/aws-serverless-ecommerce-platform/blob/master/tools/package#L50-L54>)
so that this can be fully automated?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBF764G3H6JAD4MMTGLS22DG7ANCNFSM4WAVUTYQ>
.
|
For the generic case, that means just checking for an environment variable and letting other users manage it? |
|
Oh, I see. You're thinking of customers also running this benchmark by
themselves, and not us (maintainers) only - Did I get this right?
If that's the case, yes, it'd have to be a default for us (our S3 bucket in
our Powertools account), and if customers want to run that they can
override it. I think for customers in general, it might be best to provide
guidance on how to use Python Tuna to generate flame graphs to measure
their overall import time, since they might use more than just the Core
utilities + other libraries like Requests which increase a lot in startup
…On Wed, 20 Jan 2021 at 13:11, Nicolas Moutschen ***@***.***> wrote:
Create a bucket under Powertools account - this will get us closer to
automate and check for regressions
For the generic case, that means just checking for an environment variable
and letting other users manage it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBHXCMPIDBBW3766Y33S23B5XANCNFSM4WAVUTYQ>
.
|
heitorlessa
reviewed
Feb 9, 2021
heitorlessa
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
Add a benchmark that deploys Lambda functions with/without Lambda Powertools to measure the performance impact of using it.
Checklist
Breaking change checklist
None
RFC issue #: None
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.